Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround botocore bug in S3 URL Handler backend (Cherry-pick of #19056) #19110

Merged
merged 3 commits into from
Jun 5, 2023

Conversation

WorkerPants
Copy link
Member

See boto/botocore#2948 for the upstream bug fix.

This only occurs for toekn-based auth, and therefore wasn't caught in tests or in local testing.

See boto/botocore#2948 for the upstream bug fix.

This only occurs for toekn-based auth, and therefore wasn't caught in
tests or in local testing.
@WorkerPants WorkerPants added the category:bugfix Bug fixes for released features label May 23, 2023
@thejcannon thejcannon merged commit f413a2e into 2.16.x Jun 5, 2023
@thejcannon thejcannon deleted the cherry-pick-19056-to-2.16.x branch June 5, 2023 14:43
huonw added a commit that referenced this pull request Jun 6, 2023
This adjusts the cherry picking to create the PRs with a milestone
attached, so that they're surfaced in the milestone views like
https://github.com/pantsbuild/pants/milestone/58, alongside any pending
issues and not-yet-cherrypicked PRs.

In particular, if a PR is going to be cherry-picked, it'll have the
milestone attached and be visible in that view (and any issues it's
fixing may also have it tagged)... but once PR merges to `main`, it and
any associated issues will be closed. This means they disappear from the
milestone view, but there's still work remaining to actually fix them
for that milestone: landing the cherry-pick. Pending cherry-pick PRs
_can_ be discovered by doing a search like `base:2.17.x`
https://github.com/pantsbuild/pants/pulls?q=is%3Apr+is%3Aopen+base%3A2.17.x
but it's nice to have only one place to check (the milestone view)
rather than needing to remember to also construct that search manually.

This is a response to #19110
sitting around for a while and delaying 2.16, due to flaky CI failures:
it was hard to notice.

See also
https://pantsbuild.slack.com/archives/C0D7TNJHL/p1685929902870459 /
https://chat.pantsbuild.org/t/12317552/looks-like-https-github-com-pantsbuild-pants-pull-19110-neve#4a387fb1-fc0c-4395-9160-74adf8ab7944

(This will cause some conflicts with #19230, but this PR is a quick win
that's easily ported over.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:bugfix Bug fixes for released features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants