Improve test for ignored default ports to check that the port itself is still there

Robin de Graaf · Robin de Graaf · commit d068b4c4e1fd · 2020-03-08T18:42:41.000Z
diff --git a/tests/UriTest.php b/tests/UriTest.php
@@ -68,13 +68,15 @@ public function testPortIsIgnoredWhenDefaultForSchemeHttp(): void
     {
         $uri = new Uri('http://devvoh.com:80');
 
+        self::assertSame(80, $uri->getPort());
         self::assertSame('http://devvoh.com', $uri->getUriString());
     }
 
     public function testPortIsIgnoredWhenDefaultForSchemeHttps(): void
     {
         $uri = new Uri('https://devvoh.com:443');
 
+        self::assertSame(443, $uri->getPort());
         self::assertSame('https://devvoh.com', $uri->getUriString());
     }
 

Original file line number	Diff line number	Diff line change
`@@ -68,13 +68,15 @@ public function testPortIsIgnoredWhenDefaultForSchemeHttp(): void`
`68`	`68`	`{`
`69`	`69`	`$uri = new Uri('http://devvoh.com:80');`
`70`	`70`
	`71`	`+ self::assertSame(80, $uri->getPort());`
`71`	`72`	`self::assertSame('http://devvoh.com', $uri->getUriString());`
`72`	`73`	`}`
`73`	`74`
`74`	`75`	`public function testPortIsIgnoredWhenDefaultForSchemeHttps(): void`
`75`	`76`	`{`
`76`	`77`	`$uri = new Uri('https://devvoh.com:443');`
`77`	`78`
	`79`	`+ self::assertSame(443, $uri->getPort());`
`78`	`80`	`self::assertSame('https://devvoh.com', $uri->getUriString());`
`79`	`81`	`}`
`80`	`82`