Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make benchmark inputs deterministic #13535

Open
DaniPopes opened this issue Dec 23, 2024 · 4 comments · May be fixed by #13536
Open

Make benchmark inputs deterministic #13535

DaniPopes opened this issue Dec 23, 2024 · 4 comments · May be fixed by #13536
Labels
C-benchmark A change that impacts how or what we benchmark D-good-first-issue Nice and easy! A great choice to get started

Comments

@DaniPopes
Copy link
Member

DaniPopes commented Dec 23, 2024 •
edited
Loading

Describe the feature

there are a few benchmarks that use default proptest to generate their inputs, however this is not ideal because the randomness creates a lot of noise on codspeed

these should be changed to use the deterministic proptest runner (TestRunner::deterministic()) or rng (TestRng::deterministic_rng) when creating inputs

you can find all occurences by searching for "proptest" under benches/ paths

Additional context

No response
@DaniPopes DaniPopes added the C-benchmark A change that impacts how or what we benchmark label Dec 23, 2024
@DaniPopes DaniPopes added the D-good-first-issue Nice and easy! A great choice to get started label Dec 23, 2024
@hoank101
Copy link
Contributor

hi @DaniPopes i can do it

@hoank101 hoank101 linked a pull request Dec 23, 2024 that will close this issue
Draft
@rutefig
Copy link

rutefig commented Dec 24, 2024

May I pick this up?

@aidenwong812
Copy link

Can I attempt this issue?

@ekumamatthew
Copy link

Can I be assigned to this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-benchmark A change that impacts how or what we benchmark D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: make benchmark inputs deterministic hoank101/reth
5 participants
@rutefig @DaniPopes @ekumamatthew @aidenwong812 @hoank101