Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add state validation to tx conditionals #14617

Open
mattsse opened this issue Feb 20, 2025 · 2 comments
Open

Add state validation to tx conditionals #14617

mattsse opened this issue Feb 20, 2025 · 2 comments
Assignees
@cyber-excel10
Labels
A-op-reth Related to Optimism and op-reth A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Feb 20, 2025

Describe the feature

we still have this todo:

reth/crates/optimism/rpc/src/eth/ext.rs

Line 123 in 2c06923

// TODO: check condition against state

which worldchain has a reference for:

https://github.com/worldcoin/world-chain/blob/a73be0740d65b533db0c5b986e46e83252fc77da/world-chain-builder/crates/world/rpc/src/transactions.rs#L181

because this isn't very cheap, we need to guard concurrent access here and introduce a tokio semaphore in this impl that restricts how many conditionals we can handle in parallel.

TODO

  • add missing account validation logic
  • add semaphor to guard access

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Feb 20, 2025
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started A-rpc Related to the RPC implementation A-op-reth Related to Optimism and op-reth and removed S-needs-triage This issue needs to be labelled labels Feb 20, 2025
@Ayushdubey86
Copy link

hi, can i take this? have raised pr for last one #14603

@mattsse mattsse mentioned this issue Feb 21, 2025
Closed
@cyber-excel10
Copy link

Can I try solving this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cyber-excel10 cyber-excel10

Labels
A-op-reth Related to Optimism and op-reth A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mattsse @Ayushdubey86 @cyber-excel10