Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce OpPooledTx trait #14635

Open
klkvr opened this issue Feb 21, 2025 · 2 comments
Open

Introduce OpPooledTx trait #14635

klkvr opened this issue Feb 21, 2025 · 2 comments
Assignees
Labels
A-block-building Related to block building A-op-reth Related to Optimism and op-reth A-tx-pool Related to the transaction mempool D-good-first-issue Nice and easy! A great choice to get started

Comments

@klkvr
Copy link
Member

klkvr commented Feb 21, 2025

Describe the feature

We need to provide op payload builder with access to conditionals and encoded bytes of transaction

/// The estimated size of this transaction, lazily computed.
estimated_tx_compressed_size: OnceLock<u64>,

We can solve this with an additional trait for op pooled transaction which would need to have MaybeConditionalTransaction and PoolTransaction as supertraits.

pub trait MaybeConditionalTransaction {

Once the trait is introduced we can change bounds for OpPayloadBuilder to enforce it

Pool: TransactionPool<Transaction: PoolTransaction<Consensus = N::SignedTx>>,

TODO

  • introduce trait OpPooledTx: MaybeConditionalTransaction

Additional context

No response

@klkvr klkvr added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Feb 21, 2025
@emhane emhane added A-tx-pool Related to the transaction mempool A-op-reth Related to Optimism and op-reth and removed C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Feb 21, 2025
@emhane emhane added the A-block-building Related to block building label Feb 21, 2025
@mattsse mattsse added the D-good-first-issue Nice and easy! A great choice to get started label Feb 21, 2025
@VeerChaurasia
Copy link
Contributor

hey @klkvr can i work on this ?

@mattsse
Copy link
Collaborator

mattsse commented Feb 21, 2025

@VeerChaurasia assigned, btw #14632 this is somewhat related

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-block-building Related to block building A-op-reth Related to Optimism and op-reth A-tx-pool Related to the transaction mempool D-good-first-issue Nice and easy! A great choice to get started
Projects
Status: Todo
Development

No branches or pull requests

4 participants