Make PayloadOrAttributes generic over ExecutionData

[mattsse]

reth/crates/payload/primitives/src/payload.rs

Lines 7 to 15 in 9cb2a1e

	/// Either an [`ExecutionPayload`] or a type that implements the [`PayloadAttributes`] trait.
	///
	/// This is a helper type to unify pre-validation of version specific fields of the engine API.
	#[derive(Debug)]
	pub enum PayloadOrAttributes<'a, Attributes> {
	/// An [`ExecutionPayload`] and optional parent beacon block root.
	ExecutionPayload {
	/// The inner execution payload
	payload: &'a ExecutionPayload,

currently used the concrete ethereum payload type ExecutionData

we can change this with a generic Payload

we can further simplify this enum variant to ExecutionPayload(&'a Payload) if we add a parent_beaconblock fn to

reth/crates/engine/primitives/src/lib.rs

Line 44 in 9cb2a1e

pub trait ExecutionPayload:

TODO

• change ExecutionPayload variant
• introduce fn withdrawals and fn parent_beacon_block to trait ExecutionPayload
• update impl

  reth/crates/engine/primitives/src/lib.rs

  Line 57 in 9cb2a1e

  impl ExecutionPayload for ExecutionData {

• update constructors calls, e.g.: moving this up

reth/crates/rpc/rpc-engine-api/src/engine_api.rs

Line 152 in 9cb2a1e

.new_payload(ExecutionData { payload, sidecar: ExecutionPayloadSidecar::none() })

to

reth/crates/rpc/rpc-engine-api/src/engine_api.rs

Line 140 in 9cb2a1e

let payload = ExecutionPayload::from(payload);

ref #14618

cc @yohkaz

FYI @emhane

[yohkaz]

Hey, I can have a look as well :)