Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eth_blobBaseFee #6330

Closed
allnil opened this issue Feb 1, 2024 · 3 comments · Fixed by #6721
Closed

Add eth_blobBaseFee #6330

allnil opened this issue Feb 1, 2024 · 3 comments · Fixed by #6721
Assignees
@allnil
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@allnil
Copy link
Contributor

allnil commented Feb 1, 2024

Describe the feature

Implement upcoming changes to eth_feeHistory: ethereum/execution-apis#486
@mattsse

Additional context

No response
@allnil allnil added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Feb 1, 2024
@DaniPopes DaniPopes removed the S-needs-triage This issue needs to be labelled label Feb 1, 2024
@allnil allnil mentioned this issue Feb 6, 2024
Merged
@mattsse mattsse mentioned this issue Feb 7, 2024
Merged
@allnil allnil mentioned this issue Feb 7, 2024
Merged
@Rjected Rjected changed the title Add eth_blobBaseFee; add blobs to eth_feeHistory Add eth_blobBaseFee Feb 15, 2024
@Rjected Rjected added D-good-first-issue Nice and easy! A great choice to get started A-rpc Related to the RPC implementation labels Feb 15, 2024
@AbnerZheng
Copy link
Contributor

Can I give it a try?

@mattsse
Copy link
Collaborator

mattsse commented Feb 21, 2024 •
edited
Loading

oh yeah, we added this already but apparently the name changed:

reth/crates/rpc/rpc/src/eth/api/server.rs

Lines 301 to 305 in 84b1328

/// Handler for: `eth_blobGasPrice`
async fn blob_gas_price(&self) -> Result<U256> {
trace!(target: "rpc::eth", "Serving eth_blobGasPrice");
return Ok(EthApi::blob_gas_price(self).await?)
}

would you like to submit a PR that renames this accordingly?

@AbnerZheng
Copy link
Contributor

Sure

This was referenced Feb 21, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@allnil allnil

Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: rename blob_gas_price to blob_base_fee AbnerZheng/reth
5 participants
@Rjected @AbnerZheng @mattsse @allnil @DaniPopes