Ungrouped tests should have default group assigned (#623)

Fixes #622

Author: Slamdunk

src/Runners/PHPUnit/SuiteLoader.php

@@ -38,6 +38,7 @@
 use function ksort;
 use function preg_match;
 use function sprintf;
+use function strpos;
 use function strrpos;
 use function substr;
 use function trim;
@@ -323,7 +324,12 @@ private function getMethodTests(ParsedClass $class, ReflectionMethod $method): a
     {
         $result = [];
 
+        /** @var string[] $groups */
         $groups = Test::getGroups($class->getName(), $method->getName());
+        if ($this->containsOnlyVirtualGroups($groups)) {
+            $groups[] = 'default';
+        }
+
         if (! $this->testMatchGroupOptions($groups)) {
             return $result;
         }
@@ -506,4 +512,20 @@ private function warmCoverageCache(): void
 
         $this->output->writeln('done [' . $timer->stop()->asString() . ']');
     }
+
+    /**
+     * @see PHPUnit\Framework\TestCase::containsOnlyVirtualGroups
+     *
+     * @param string[] $groups
+     */
+    private function containsOnlyVirtualGroups(array $groups): bool
+    {
+        foreach ($groups as $group) {
+            if (strpos($group, '__phpunit_') !== 0) {
+                return false;
+            }
+        }
+
+        return true;
+    }
 }

test/Unit/Runners/PHPUnit/SuiteLoaderTest.php

@@ -378,6 +378,14 @@ public function testTestMethodsFromErroringDataProviderReturnTheSimpleMethodToBe
         static::assertCount(3, $loader->getTestMethods());
     }
 
+    public function testUngroupedTestShouldHaveDefaultGroupAssigned(): void
+    {
+        $this->bareOptions['--path']  = $this->fixture('group_default');
+        $this->bareOptions['--group'] = 'default';
+        $loader                       = $this->loadSuite();
+        static::assertCount(2, $loader->getTestMethods());
+    }
+
     /**
      * @return string[]
      */

test/fixtures/group_default/GroupDefaultTest.php

@@ -0,0 +1,31 @@
+<?php
+
+declare(strict_types=1);
+
+namespace ParaTest\Tests\fixtures\passing_tests;
+
+use PHPUnit\Framework\TestCase;
+
+final class GroupDefaultTest extends TestCase
+{
+    public function testTruth(): void
+    {
+        $this->assertTrue(true);
+    }
+
+    /**
+     * @covers ParaTest\Tests\fixtures\passing_tests\GroupDefaultTest
+     */
+    public function testTruthWithCovers(): void
+    {
+        $this->assertTrue(true);
+    }
+
+    /**
+     * @group group1
+     */
+    public function testFalsehood(): void
+    {
+        $this->assertFalse(false);
+    }
+}

test/fixtures/group_default/GroupNonDefaultTest.php

@@ -0,0 +1,18 @@
+<?php
+
+declare(strict_types=1);
+
+namespace ParaTest\Tests\fixtures\passing_tests;
+
+use PHPUnit\Framework\TestCase;
+
+/**
+ * @group group1
+ */
+final class GroupNonDefaultTest extends TestCase
+{
+    public function testTruth(): void
+    {
+        $this->assertTrue(true);
+    }
+}