From 6830fdb38b06f8b36695367378c65ac478d4cac3 Mon Sep 17 00:00:00 2001 From: Paul Wolak Date: Thu, 22 Oct 2015 13:56:31 -0600 Subject: [PATCH 1/2] Adds more detailed message other then "This means a PHPUnit process has crashed" when printing feedback --- src/ParaTest/Runners/PHPUnit/ResultPrinter.php | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/src/ParaTest/Runners/PHPUnit/ResultPrinter.php b/src/ParaTest/Runners/PHPUnit/ResultPrinter.php index e15541f7..3fb7e5e8 100644 --- a/src/ParaTest/Runners/PHPUnit/ResultPrinter.php +++ b/src/ParaTest/Runners/PHPUnit/ResultPrinter.php @@ -189,7 +189,19 @@ public function printResults() */ public function printFeedback(ExecutableTest $test) { - $reader = new Reader($test->getTempFile()); + try { + $reader = new Reader($test->getTempFile()); + } catch (\InvalidArgumentException $e) { + throw new \RuntimeException(sprintf( + "%s\n" . + "The process: %s\n" . + "This means a PHPUnit process was unable to run \"%s\"\n" . + "This is is a good starting point for debugging.\n", + $e->getmessage(), + $test->getLastCommand(), + $test->getPath() + )); + } if (!$reader->hasResults()) { throw new \RuntimeException(sprintf( "The process: %s\nLog file \"%s\" is empty.\n" . From 8f44372616dc8d27ed59467a4d3694fde2c8d536 Mon Sep 17 00:00:00 2001 From: Paul Wolak Date: Thu, 29 Oct 2015 11:11:24 -0600 Subject: [PATCH 2/2] Updates printing feedback error message --- src/ParaTest/Runners/PHPUnit/ResultPrinter.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/ParaTest/Runners/PHPUnit/ResultPrinter.php b/src/ParaTest/Runners/PHPUnit/ResultPrinter.php index 3fb7e5e8..b90a755c 100644 --- a/src/ParaTest/Runners/PHPUnit/ResultPrinter.php +++ b/src/ParaTest/Runners/PHPUnit/ResultPrinter.php @@ -195,8 +195,7 @@ public function printFeedback(ExecutableTest $test) throw new \RuntimeException(sprintf( "%s\n" . "The process: %s\n" . - "This means a PHPUnit process was unable to run \"%s\"\n" . - "This is is a good starting point for debugging.\n", + "This means a PHPUnit process was unable to run \"%s\"\n" , $e->getmessage(), $test->getLastCommand(), $test->getPath()