Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multi account config save behavior #19

Open
jnierodzik opened this issue Sep 7, 2023 · 1 comment
Open

multi account config save behavior #19

jnierodzik opened this issue Sep 7, 2023 · 1 comment
Assignees
@jnierodzik
Labels
fix Change that fixes something that isn't working as expected

Comments

@jnierodzik
Copy link
Contributor

Scenarios exist where account IDs are duplicating creating inability to save/remove entires
@jnierodzik jnierodzik added the fix Change that fixes something that isn't working as expected label Sep 7, 2023
@jnierodzik jnierodzik self-assigned this Sep 7, 2023
@jnierodzik
Copy link
Contributor Author

@MattMaginniss - please verify resolution

jnierodzik added a commit that referenced this issue Sep 9, 2023
@jnierodzik
fix-feat/multi-account-feature-fixes
d86ee79 
Addresses issues:
- #18 fix/returns not working in multi account
- #19 fix/multi account save behavior
- #20 fix/active account not persisted across sessions
- #21 fix/invalid credentials issue with only one account
- #17 feat/trim whitespace on credentials

Changes to be committed:
-	modified:   src/api.ts
-	modified:   src/options.ts
-	modified:   src/popup.ts
-	modified:   src/storage.ts
-	modified:   src/ux.ts
-	modified:   static/manifest.json
-	modified:   static/options.html
-	modified:   static/popup.html
-	modified:   static/sidepanel.html
-	modified:   styles/common.scss
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jnierodzik jnierodzik

Labels
fix Change that fixes something that isn't working as expected
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jnierodzik