Skip to content

Commit 4e7c9e7

Browse files
niklasad1ggwpez
andauthored
rpc server: fix deny unsafe on RpcMethods::Auto (#5678)
Close #5677 I made a nit when I moved this code: https://github.com/paritytech/polkadot-sdk/blob/v1.14.0-rc1/substrate/client/service/src/lib.rs#L379-#L385 in #4792 Thus: - (ip.is_loopback(), RpcMethods::Auto) -> allow unsafe - (!ip.is_loopback(), RpcMethods::Auto) -> deny unsafe --------- Co-authored-by: ggwpez <ggwpez@users.noreply.github.com>
1 parent 0f7acb5 commit 4e7c9e7

File tree

2 files changed

+15
-1
lines changed

2 files changed

+15
-1
lines changed

prdoc/pr_5678.prdoc

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
title: 'rpc server: fix deny unsafe on RpcMethods::Auto'
2+
doc:
3+
- audience: Node User
4+
description: |-
5+
Close #5677
6+
7+
I made a nit when I moved this code: https://github.com/paritytech/polkadot-sdk/blob/v1.14.0-rc1/substrate/client/service/src/lib.rs#L379-#L385 in https://github.com/paritytech/polkadot-sdk/pull/4792
8+
9+
Thus:
10+
- (ip.is_loopback(), RpcMethods::Auto) -> allow unsafe
11+
- (!ip.is_loopback(), RpcMethods::Auto) -> deny unsafe
12+
crates:
13+
- name: sc-rpc-server
14+
bump: patch

substrate/client/rpc-servers/src/utils.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,7 @@ pub(crate) fn get_proxy_ip<B>(req: &http::Request<B>) -> Option<IpAddr> {
284284
/// Get the `deny_unsafe` setting based on the address and the RPC methods exposed by the interface.
285285
pub fn deny_unsafe(addr: &SocketAddr, methods: &RpcMethods) -> DenyUnsafe {
286286
match (addr.ip().is_loopback(), methods) {
287-
| (_, RpcMethods::Unsafe) | (false, RpcMethods::Auto) => DenyUnsafe::No,
287+
(_, RpcMethods::Unsafe) | (true, RpcMethods::Auto) => DenyUnsafe::No,
288288
_ => DenyUnsafe::Yes,
289289
}
290290
}

0 commit comments

Comments
 (0)