Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing suppressed and submitted_in from Nominations #332

Open
kianenigma opened this issue Mar 12, 2021 · 6 comments
Open

Consider removing suppressed and submitted_in from Nominations #332

kianenigma opened this issue Mar 12, 2021 · 6 comments
Labels
A2-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. T1-FRAME This PR/Issue is related to core FRAME, the framework.

Comments

@kianenigma
Copy link
Contributor

If paritytech/substrate#8197 gets merged, or generally we get full slash reversal, we no longer use neither submitted_in nor suppressed if the Nomination struct in pallet-staking. Consider removing these in favour of state-space.
@hirschenberger
Copy link
Contributor

I'd like to work on this. Anything special to consider?

@kianenigma
Copy link
Contributor Author

This is just a migration (if any at all) and very small code changes, and the PR that is blocking it might not get merged anytime soon, so I'd recommend waiting on it.

@hirschenberger
Copy link
Contributor

Ah, nevermind. I missed that paritytech/substrate#8197 was unmerged.

@stale
Copy link

stale bot commented Jul 7, 2021

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A5-stale label Jul 7, 2021
@kianenigma
Copy link
Contributor Author

meh, should stay around for now.

@juangirini juangirini transferred this issue from paritytech/substrate Aug 24, 2023
@the-right-joyce the-right-joyce added A2-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. T1-FRAME This PR/Issue is related to core FRAME, the framework. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. and removed A5-stale labels Aug 25, 2023
claravanstaden pushed a commit to Snowfork/polkadot-sdk that referenced this issue Dec 8, 2023
@Rizziepit
System benchmarks & switch to WASM (paritytech#332)
166045c 
* Fix rococo-runtime naming clash

* Use wasm in benchmarks

* Add frame_system weights & benchmark wasm
helin6 pushed a commit to boolnetwork/polkadot-sdk that referenced this issue Feb 5, 2024
@JoshOrndorff
Make block gas limit accessible in EVM contracts (paritytech#332)
e798ae5 
* Move associated type to pallet evm

* wire it into the evm backend

* Fix test mocks
@kianenigma
Copy link
Contributor Author

Ironically, this will be needed for polkadot-fellows/RFCs#86 which is getting good traction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A2-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
(Nominated) Proof of Stake
Status: 📕 Backlog
Runtime / FRAME
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
4 participants
@hirschenberger @juangirini @kianenigma @the-right-joyce