Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow removing litep2p from dependencies #4856

Open
nazar-pc opened this issue Jun 21, 2024 · 3 comments
Open

Allow removing litep2p from dependencies #4856

nazar-pc opened this issue Jun 21, 2024 · 3 comments

Comments

@nazar-pc
Copy link
Contributor

nazar-pc commented Jun 21, 2024

litep2p causes multiple issues downstream for us at Subspace. Older release brought vulnerable ed25519-dalek version that we had to suppress in cargo audit, now I noticed it pulls a large number of extra dependencies, including OpenSSL that I was trying to avoid all this time and was pretty successful at it.

The fact that it it enabled by default and not possible to disable is very undesirable, please consider making it an option just like it is possible to disable RocksDB right now for databases.

@nazar-pc
Copy link
Contributor Author

While it seems that litep2p is here to stay for better or worse, it is at least possible to configure transports with paritytech/litep2p#192 that should ideally be ported over here as well so we can simply not enable protocols we are not interested in downstream.

@nazar-pc
Copy link
Contributor Author

nazar-pc commented Sep 5, 2024

#5562 is related to this one

@bkchr
Copy link
Member

bkchr commented Sep 6, 2024

CC @paritytech/networking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants