Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fatxpool: add LRUCache for views. #5474

Open
Tracked by #5472
michalkucharczyk opened this issue Aug 27, 2024 · 1 comment
Open
Tracked by #5472

fatxpool: add LRUCache for views. #5474

michalkucharczyk opened this issue Aug 27, 2024 · 1 comment
Assignees
@michalkucharczyk
Labels
T0-node This PR/Issue is related to the topic “node”.

Comments

@michalkucharczyk
Copy link
Contributor

Currently the number of views can grow w/o any limits together with the number of forks. This is not likely to happen, but could be possible e.g. if finalization is stalled. LRU Cache should prevent this. I would start with 5 active and 10 inactive views.
@michalkucharczyk michalkucharczyk self-assigned this Aug 27, 2024
@michalkucharczyk michalkucharczyk added the T0-node This PR/Issue is related to the topic “node”. label Aug 27, 2024
@michalkucharczyk michalkucharczyk mentioned this issue Aug 27, 2024
Open
@Polkadot-Forum
Copy link

This issue has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/the-fork-aware-transaction-pool/10468/14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michalkucharczyk michalkucharczyk

Labels
T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michalkucharczyk @Polkadot-Forum