Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure nomination pool members can directly stake and vice versa. #5742

Open
Ank4n opened this issue Sep 17, 2024 · 2 comments
Open

Ensure nomination pool members can directly stake and vice versa. #5742

Ank4n opened this issue Sep 17, 2024 · 2 comments
Assignees
Labels
D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. T2-pallets This PR/Issue is related to a particular pallet. T8-polkadot This PR/Issue is related to/affects the Polkadot network.

Comments

@Ank4n
Copy link
Contributor

Ank4n commented Sep 17, 2024

Context

As a side effect of #3905, it becomes possible for a direct staker to reuse the staked (frozen) funds to be used for participating in a pool (hold) as well. Essentially double staking with the same funds.

This is prevented currently by pallet-delegated-staking not allowing direct stakers to delegate, as well as by pallet-staking only taking free balance into account.

Task

As a followup to #5501, remove the condition to not be a direct staker for bonding to pool.

@Ank4n Ank4n added T2-pallets This PR/Issue is related to a particular pallet. T8-polkadot This PR/Issue is related to/affects the Polkadot network. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. labels Sep 17, 2024
@rainbow-promise
Copy link

Hello @Ank4n I would like to take this issue.

@Ank4n
Copy link
Contributor Author

Ank4n commented Sep 20, 2024

Hello @Ank4n I would like to take this issue.

@rainbow-promise Thanks for your interest. This issue can only be done post #5501, and only requires one line to remove. I would suggest to pick up an issue with C1-Mentor.

@Ank4n Ank4n self-assigned this Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. T2-pallets This PR/Issue is related to a particular pallet. T8-polkadot This PR/Issue is related to/affects the Polkadot network.
Projects
None yet
Development

No branches or pull requests

2 participants