Mock signature verify #2952
Closed
Mock signature verify #2952
+893
−777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
mergify bot
added a commit
that referenced
this pull request
Nov 1, 2022
cc @xlc After looking at #2952, I thought that the approach in this PR is a better idea. As shown in the changes to `runtime_host.rs` and `read_only_runtime_host.rs`, you now have a new variant called `SignatureVerification` that allows you to overwrite the verification if you so desire. As I was implemented this PR, I noticed that the implementation of `ext_crypto_ecdsa_verify` loads the message from the first parameter, which is actually the signature. Oops. This is fixed at the same time. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2948
On top of #2950. the additional diff is 20d9235
Not yet tested.
Will mark this ready once I successfully get it e2e working with AcalaNetwork/chopsticks#13