Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

frameless-node-template link resolves in 404 #14629

Open
d-moos opened this issue Jul 25, 2023 · 11 comments
Open

frameless-node-template link resolves in 404 #14629

d-moos opened this issue Jul 25, 2023 · 11 comments
Assignees
Labels
I6-documentation Documentation needs fixing, improving or augmenting.

Comments

@d-moos
Copy link

d-moos commented Jul 25, 2023

//! > example of which can be found [here](https://github.com/JoshOrndorff/frameless-node-template).

Hey @kianenigma ,
It looks like the frameless-node-template has been removed recently.
Should this link be replaced with the Tuxedo repository or is the node-template available somewhere else?

@github-actions github-actions bot added the J2-unconfirmed Issue might be valid, but it’s not yet known. label Jul 25, 2023
@liamaharon
Copy link
Contributor

cc @JoshOrndorff

@liamaharon liamaharon added I6-documentation Documentation needs fixing, improving or augmenting. and removed J2-unconfirmed Issue might be valid, but it’s not yet known. labels Jul 25, 2023
@shawntabrizi
Copy link
Member

I think it was asked to be hidden during the academy or something like that.

@kianenigma
Copy link
Contributor

I like the idea of Tuxedo

@JoshOrndorff
Copy link
Contributor

cc @nukemandan Gatekeeping that content broke the Substrate docs and people noticed immediately. By making content closed we are preventing people from learning Substrate.

@nuke-web3
Copy link
Contributor

As discussed internal to the PBA, this needed to happen for this moment because this repo was build for PBA to use as a graded assignment in full or in part. All graded assignments we must keep private by policy for now because we don't want solutions to leak (primarily). As it is presently unclear what aspects are to be gradaed from this repo, it needed to be hidden till those aspects are removed completely.

Word from our director on this issue:

[I am] Fine with formative, non-graded assignments to be open as long as summative, graded assignments are closed.

So after the PBA we can work to bring back this in some form. 😀
I also vote for Tuxedo being used in place for now and perhaps tightly coupled to ant FRAME-less template to learn from latter as IIUC Tuxedo was built using that template.

@nuke-web3
Copy link
Contributor

Also @JoshOrndorff if you read your own student roster, you will find all people in this issue are in now, or have been at the Academy.

@d-moos
Copy link
Author

d-moos commented Jul 26, 2023

Thanks for replying so swiftly. :)
The reasoning behind makes sense to me and thus the issue would be resolved from my pov 👍

@liamaharon
Copy link
Contributor

liamaharon commented Jul 26, 2023

I think this highlights a larger issue where we are unaware when doc links become broken, which really should be avoided.

@kianenigma maybe you have already considered such tools in your docs overhaul effort, but it seems we should add something like a CI job that runs a tool like https://github.com/deadlinks/cargo-deadlinks ?

Screenshot 2023-07-26 at 13 06 36

@JoshOrndorff
Copy link
Contributor

JoshOrndorff commented Aug 2, 2023

The PBA3 assignment is over and I've made the repo in question public again. It will remain public henceforth as far as I'm in control of it.

@kianenigma
Copy link
Contributor

Glad to see this resolved; But, I'd still leave this open to introduce a link checker for external links to our repo.

@ggwpez
Copy link
Member

ggwpez commented Aug 14, 2023

Glad to see this resolved; But, I'd still leave this open to introduce a link checker for external links to our repo.

Yea its quite annoying. Added paritytech/polkadot-sdk#134 and paritytech/polkadot-sdk#993.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I6-documentation Documentation needs fixing, improving or augmenting.
Projects
None yet
Development

No branches or pull requests

9 participants