Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Fold's reducer argument to BinaryOperator<SingleValueExpression> or similar #284

Open
jvdb opened this issue Feb 13, 2019 · 0 comments
Assignees

Comments

@jvdb
Copy link
Contributor

jvdb commented Feb 13, 2019

The reducer argument to Fold is now BinaryOperator<ValueExpression> but should be BinaryOperator<SingleValueExpression> or perhaps even BinaryOperator<Value>. However, we often pass a ValueExpression such as Shorthand::add as a method reference, which would then no longer work. Experiment with a solution to this.

Possibly, we can make SingleValueExpression-versions of common operations such as the logical and binary operators. We first need to find out of we can pull this off in a clean way with the Java type system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant