fix(test): migrate ThemesIndexControllerTest to Fixture Factories #584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses passbolt#536 - Remove usage of legacy AccountSettings fixture. Changes: - Replace legacy $fixtures array with UserFactory::make() - Use logInAs($user) instead of logInAsUser() This follows the pattern already used in ThemesSelectControllerTest.php in the same directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove usage of legacy AccountSettings fixture in ThemesIndexControllerTest
This pull request is a (multiple allowed):
Checklist
What you did
Addresses #536 - Migrate ThemesIndexControllerTest to Fixture Factories.
Changes:
$fixtures = ['plugin.Passbolt/AccountSettings.AccountSettings']arrayUserFactory::make()->user()->persist()for test user creationlogInAsUser()withlogInAs($user)This follows the pattern already established in
ThemesSelectControllerTest.phpin the same directory. The test only needs an authenticated user to call the themes index endpoint - it doesn't require pre-existing theme settings.All 6 theme controller tests pass.