Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Path Element Introduction #2929

Closed
1 task done
erichfi opened this issue Sep 30, 2024 · 1 comment · Fixed by passportxyz/passport-scorer#696
Closed
1 task done

Version Path Element Introduction #2929

erichfi opened this issue Sep 30, 2024 · 1 comment · Fixed by passportxyz/passport-scorer#696
Assignees

Comments

@erichfi
Copy link
Collaborator

erichfi commented Sep 30, 2024

User Story:

As a developer,
I want to have a version path element in API endpoints,
So that I can manage and integrate future API versions smoothly.

Acceptance Criteria

GIVEN the current API versioning,
WHEN new API requests are made,
THEN endpoints should reflect the version path, e.g., /v2/.

Product & Design Links:

N/A

Tech Details:

  • Introduce the /v2/ versioning in the API endpoints.
  • Make v2 available on a feature flag; it should not be in production yet.
  • Clean up the current v2 for the registry and duplicate tests for v2.

Open Questions:

  • Should /v2 be made unavailable on gitcoin.co, and how would this be managed with load balancer rules?

Notes/Assumptions:

  • This will be the standard path for all future versions.
  • The /v2 should only be available on the new domain, passport.xyz. 2 options here:
    • python code
    • or the preferred way: in the load balancer (@larisa17 can provide guidance here)
@nutrina
Copy link
Collaborator

nutrina commented Sep 30, 2024

This ticket basically says:

  • take the current version of the API
  • clone it
  • make it available on the /v2 subpath without any other modification
  • feature flag it, it should not be available in production
  • clean up the v2 for the registry with this occasion (delete the current v2)
  • also duplicate the tests and have them run against the v2 version of the api

Question:

  • do we want to make sure the /v2 is not available on gitcoin.co --> this can be achieved via load balancer rules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Product/UX Review
Development

Successfully merging a pull request may close this issue.

3 participants