This repository has been archived by the owner on Dec 30, 2018. It is now read-only.
Masonry directive as an element doesn't create columns #169
Comments
vrockai
changed the title
|
This also happened to me, using bower install. |
|
I can reproduce this with the demo. The documentation does seem to be at odds. It says:
But then the examples that follow use Seems like a pull request could:
@passy Unless there's a bug disallowing use of |
blakerego
added a commit
to blakerego/angular-masonry
that referenced
this issue
Mar 12, 2017
The masonry directive does not properly create columns when used as an element. To avoid confusion, I updated the directive code to restrict usage to attribute mode only (this could always be changed back, if a subsequent fix was made to fix element loading). I have also updated the repository README documentation to provide a more accurate account of how the masonry directive currently works. This issue was first brought up here: passy#169. This will invalidate uses of this directive as an element. However, these uses are likely already broken.
blakerego
added a commit
to blakerego/angular-masonry
that referenced
this issue
Mar 12, 2017
The masonry directive does not properly create columns when used as an element. To avoid confusion, I updated the directive code to restrict usage to attribute mode only (this could always be changed back, if a subsequent fix was made to fix element loading). I have also updated the repository README documentation to provide a more accurate account of how the masonry directive currently works. This issue was first brought up here: passy#169 This will invalidate uses of this directive as an element. However, these uses are likely already
blakerego
added a commit
to blakerego/angular-masonry
that referenced
this issue
Mar 14, 2017
The masonry directive does not properly create columns when used as an element. To avoid confusion, I updated the directive code to restrict usage to attribute mode only (this could always be changed back, if a subsequent fix was made to fix element loading). I have also updated the repository README documentation to provide a more accurate account of how the masonry directive currently works. This issue was first brought up here: passy#169. Also updated the tests to reflect this change. BREAKING CHANGE: This will break uses of this directive as an element. However, these uses are likely already broken. closes passy#169
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In the README.md, the
masonrydirective is used as an element. It doesn't work properly (creates only a single column) for me when I use it asEdirective like:but it works well when used as
Adirective like:The text was updated successfully, but these errors were encountered: