Skip to content

Commit a4ead58

Browse files
committed
feat(componentGroups): InvalidObjectProps rename to MissingPageProps
1 parent 91aaa1b commit a4ead58

5 files changed

+121
-0
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
### component-groups-invalidObjectProps-rename-to-missingPageProps [(react-component-groups/#313)](https://github.com/patternfly/react-component-groups/pull/313)
2+
3+
In react-component-groups, we've renamed InvalidObjectProps interface to MissingPageProps
4+
5+
#### Examples
6+
7+
In:
8+
9+
```jsx
10+
%inputExample%
11+
```
12+
13+
Out:
14+
15+
```jsx
16+
%outputExample%
17+
```
18+
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,85 @@
1+
const ruleTester = require("../../ruletester");
2+
import * as rule from "./component-groups-invalidObjectProps-rename-to-missingPageProps";
3+
4+
ruleTester.run(
5+
"component-groups-invalidObjectProps-rename-to-missingPageProps",
6+
rule,
7+
{
8+
valid: [
9+
// missing import
10+
{
11+
code: `const props: InvalidObjectProps;`,
12+
},
13+
// import from wrong package
14+
{
15+
code: `import { InvalidObjectProps } from '@patternfly/react-core';`,
16+
},
17+
],
18+
invalid: [
19+
{
20+
code: `import { InvalidObjectProps } from '@patternfly/react-component-groups';
21+
const props: InvalidObjectProps;
22+
const otherProps = props as InvalidObjectProps;`,
23+
output: `import { MissingPageProps } from '@patternfly/react-component-groups';
24+
const props: MissingPageProps;
25+
const otherProps = props as MissingPageProps;`,
26+
errors: [
27+
{
28+
message: `InvalidObjectProps has been renamed to MissingPageProps.`,
29+
type: "ImportSpecifier",
30+
},
31+
{
32+
message: `InvalidObjectProps has been renamed to MissingPageProps.`,
33+
type: "TSTypeReference",
34+
},
35+
{
36+
message: `InvalidObjectProps has been renamed to MissingPageProps.`,
37+
type: "TSTypeReference",
38+
},
39+
],
40+
},
41+
// named import with alias
42+
{
43+
code: `import { InvalidObjectProps as InvObjProps } from '@patternfly/react-component-groups';`,
44+
output: `import { MissingPageProps as InvObjProps } from '@patternfly/react-component-groups';`,
45+
errors: [
46+
{
47+
message: `InvalidObjectProps has been renamed to MissingPageProps.`,
48+
type: "ImportSpecifier",
49+
},
50+
],
51+
},
52+
// imports from dist
53+
{
54+
code: `import { InvalidObjectProps } from '@patternfly/react-component-groups/dist/cjs/InvalidObject';`,
55+
output: `import { MissingPageProps } from '@patternfly/react-component-groups/dist/cjs/InvalidObject';`,
56+
errors: [
57+
{
58+
message: `InvalidObjectProps has been renamed to MissingPageProps.`,
59+
type: "ImportSpecifier",
60+
},
61+
],
62+
},
63+
{
64+
code: `import { InvalidObjectProps } from '@patternfly/react-component-groups/dist/esm/InvalidObject';`,
65+
output: `import { MissingPageProps } from '@patternfly/react-component-groups/dist/esm/InvalidObject';`,
66+
errors: [
67+
{
68+
message: `InvalidObjectProps has been renamed to MissingPageProps.`,
69+
type: "ImportSpecifier",
70+
},
71+
],
72+
},
73+
{
74+
code: `import { InvalidObjectProps } from '@patternfly/react-component-groups/dist/dynamic/InvalidObject';`,
75+
output: `import { MissingPageProps } from '@patternfly/react-component-groups/dist/dynamic/InvalidObject';`,
76+
errors: [
77+
{
78+
message: `InvalidObjectProps has been renamed to MissingPageProps.`,
79+
type: "ImportSpecifier",
80+
},
81+
],
82+
},
83+
],
84+
}
85+
);
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
import { renameInterface } from "../../helpers";
2+
3+
// https://github.com/patternfly/react-component-groups/pull/313
4+
module.exports = {
5+
meta: { fixable: "code" },
6+
create: renameInterface(
7+
{
8+
InvalidObjectProps: "MissingPageProps",
9+
},
10+
"@patternfly/react-component-groups"
11+
),
12+
};
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
import { InvalidObjectProps } from "@patternfly/react-component-groups";
2+
3+
const props: InvalidObjectProps;
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
import { MissingPageProps } from "@patternfly/react-component-groups";
2+
3+
const props: MissingPageProps;

0 commit comments

Comments
 (0)