Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New CSS tokens - warn and do a mapping for global tokens #748

Closed
1 of 3 tasks
adamviktora opened this issue Aug 26, 2024 · 0 comments · Fixed by #763
Closed
1 of 3 tasks

New CSS tokens - warn and do a mapping for global tokens #748

adamviktora opened this issue Aug 26, 2024 · 0 comments · Fixed by #763
Assignees
@adamviktora
Labels
codemod epic p1 Important for release

Comments

@adamviktora
Copy link
Contributor

adamviktora commented Aug 26, 2024 •
edited
Loading

Follow up to #733

  • Provide warnings for Literals too (string like "var(--pf-v5-whatever)") - DONE in feat(tokens): warn for CSS variables in strings #755
  • Update every global token, which is not a color token - automatically via a fix.
  • For colors, provide f.e. a hot pink color for every color so the consumers see it and then manually update to use the correct token.
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Aug 26, 2024
@adamviktora adamviktora self-assigned this Aug 26, 2024
@tlabaj tlabaj added the codemod label Aug 27, 2024
@kmcfaul kmcfaul moved this from Needs triage to Not started in PatternFly Issues Aug 27, 2024
@adamviktora adamviktora mentioned this issue Aug 28, 2024
Merged
@adamviktora adamviktora mentioned this issue Sep 10, 2024
Merged
@kmcfaul kmcfaul added the p1 Important for release label Sep 11, 2024
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamviktora adamviktora

Labels
codemod epic p1 Important for release
Projects
PatternFly Issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(tokens): provide autofix for all global tokens adamviktora/pf-codemods
4 participants
@tlabaj @kmcfaul @thatblindgeye @adamviktora