Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues encountered during early beta testing #749

Closed
4 tasks done
nicolethoen opened this issue Aug 26, 2024 · 4 comments
Closed
4 tasks done

Issues encountered during early beta testing #749

nicolethoen opened this issue Aug 26, 2024 · 4 comments

Comments

@nicolethoen
Copy link
Contributor

nicolethoen commented Aug 26, 2024

per this slack thread

We should check that the codemods all work as expected or at least output some guidance for these situations.

Having some trouble with a few react-core components; TextListVariants, TextListItemVariants, EmptyStateHeader, and EmptyStateIcon.
Screenshot 2024-08-26 at 3 28 58 PM
Screenshot 2024-08-26 at 3 24 31 PM

ToolbarItem doesn't like serach-filter as a variant. And ToolbarContent complains about bulk-select
Screenshot 2024-08-26 at 3 30 18 PM
Screenshot 2024-08-26 at 3 32 11 PM

@thatblindgeye
Copy link
Collaborator

FYI for the Toolbar updates, made in this PR in React: patternfly/patternfly-react#10042

@wise-king-sullyman
Copy link
Collaborator

The EmptyState changes do at least throw errors. It can't autofix because the EmptyStateHeader in use there doesn't have titleText or children.

@thatblindgeye
Copy link
Collaborator

Leaving this open for now in case we decide to try providing an autofix for EmptyState when there's no titleText or children to use in the current autofix. Otherwise all other tasks are complete.

@thatblindgeye
Copy link
Collaborator

Opened a separate issue for EmptyState, closing this issue as all other tasks are completed

@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

6 participants
@wise-king-sullyman @nicolethoen @thatblindgeye @adamviktora and others