Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In the pf-codemods README some rules have no fix but do include examples, we should remove those unchanging examples #767

Closed
wise-king-sullyman opened this issue Sep 16, 2024 · 5 comments
Closed

In the pf-codemods README some rules have no fix but do include examples, we should remove those unchanging examples #767

wise-king-sullyman opened this issue Sep 16, 2024 · 5 comments
Assignees
@adamviktora
Labels
codemod enhancement New feature or request p2 Nice to have for release

Comments

@wise-king-sullyman
Copy link
Collaborator

Per title, we probably don't want rules that aren't making any changes to feature the in/out example blocks, for general clarity reasons and for simplifying release notes based on our README.
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Sep 16, 2024
@adamviktora adamviktora self-assigned this Sep 18, 2024
@adamviktora
Copy link
Contributor

Oh, that's probably my mistake, I'll take the issue.

@adamviktora
Copy link
Contributor

So I checked all v6 rules and the only one with this problem is the tokensWarn rule, but it was restructured to be a fix in a recent PR #763

@tlabaj tlabaj moved this from Needs triage to Backlog in PatternFly Issues Sep 19, 2024
@adamviktora
Copy link
Contributor

@wise-king-sullyman Does it mean we should delete the example in/out files? Or removing them from README is sufficient?

@thatblindgeye thatblindgeye added enhancement New feature or request p2 Nice to have for release codemod labels Sep 24, 2024
@wise-king-sullyman
Copy link
Collaborator Author

Removing them from the readme should be sufficient

@adamviktora
Copy link
Contributor

I checked again with a script and there are no rules without a fix that would include an example in the .md file, so I will close this issue

@github-project-automation github-project-automation bot moved this from Backlog to Done in PatternFly Issues Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamviktora adamviktora

Labels
codemod enhancement New feature or request p2 Nice to have for release
Projects
PatternFly Issues
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wise-king-sullyman @thatblindgeye @adamviktora