Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moveSpecifiers helper should update dist/js and dist/dynamic paths the same way it does dist/esm #783

Closed
wise-king-sullyman opened this issue Oct 2, 2024 · 0 comments · Fixed by #784
Closed

moveSpecifiers helper should update dist/js and dist/dynamic paths the same way it does dist/esm #783

wise-king-sullyman opened this issue Oct 2, 2024 · 0 comments · Fixed by #784
Assignees
@wise-king-sullyman
Labels
bug Something isn't working PF Team

Comments

@wise-king-sullyman
Copy link
Collaborator

Currently the moveSpecifiers helper sets cjs and dynamic import paths to start just importing from the root package and not the previously requested module, it should treat cjs and dynamic imports the same way it currently treats esm imports.

Discovered during review of #779
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wise-king-sullyman wise-king-sullyman

Labels
bug Something isn't working PF Team
Projects
PatternFly Issues
Archived in project
Milestone
No milestone
1 participant
@wise-king-sullyman