Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobx-react warning on newer versions #70

Open
tomperr opened this issue Jun 20, 2023 · 1 comment
Open

mobx-react warning on newer versions #70

tomperr opened this issue Jun 20, 2023 · 1 comment

Comments

@tomperr
Copy link

tomperr commented Jun 20, 2023

Describe the problem
An import of batchingForReactDom generates a warning with newer version of mobx-react

How do you reproduce the problem?
Create a new TS/JS project that depends on the last version of patternfly/react-topology, and import VisualizationSurface component. Launch the project (in dev)
A warning appears in the browser's console : [mobx-react-lite] importing batchingForReactDom is no longer needed

Expected behavior
No warning

Is this issue blocking you?
Not really, it is just a bit dirty to keep this warning

What is your environment?

  • OS: Windows 10
  • Browser: Firefox
  • Version: 114.0.1

Any other information?
My suggestion would be to bump mobx-react to ^7.0.0, as the import of batchingForReactDom in VisualizationSurface.tsx won't be needed, so we would be able to remove it, which will remove the warning for any accepted version of this library

@tomperr tomperr changed the title mobx-react-lite warning on newer versions mobx-react warning on newer versions Jun 20, 2023
@jessiehuff jessiehuff moved this from Needs triage to Not started in PatternFly Extensions Oct 11, 2023
@lordrip
Copy link
Contributor

lordrip commented Oct 17, 2023

Here's a screenshot from a test execution showcasing the same warning

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

3 participants