Skip to content

mobx-react warning on newer versions #70

Open
@tomperr

Description

@tomperr

Describe the problem
An import of batchingForReactDom generates a warning with newer version of mobx-react

How do you reproduce the problem?
Create a new TS/JS project that depends on the last version of patternfly/react-topology, and import VisualizationSurface component. Launch the project (in dev)
A warning appears in the browser's console : [mobx-react-lite] importing batchingForReactDom is no longer needed

Expected behavior
No warning

Is this issue blocking you?
Not really, it is just a bit dirty to keep this warning

What is your environment?

  • OS: Windows 10
  • Browser: Firefox
  • Version: 114.0.1

Any other information?
My suggestion would be to bump mobx-react to ^7.0.0, as the import of batchingForReactDom in VisualizationSurface.tsx won't be needed, so we would be able to remove it, which will remove the warning for any accepted version of this library

Activity

changed the title [-]mobx-react-lite warning on newer versions[/-] [+]mobx-react warning on newer versions[/+] on Jun 20, 2023
moved this from Needs triage to Not started in PatternFly Extensionson Oct 11, 2023
lordrip

lordrip commented on Oct 17, 2023

@lordrip
Contributor

Here's a screenshot from a test execution showcasing the same warning

image

moved this from Needs triage to Backlog in PatternFly Issueson Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status

    Backlog

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @tomperr@lordrip@jessiehuff

        Issue actions

          mobx-react warning on newer versions · Issue #70 · patternfly/react-topology