Skip to content

Commit 917cd1f

Browse files
committed
fix: setting page should go back after fetching new repo url
1 parent 0152e98 commit 917cd1f

File tree

1 file changed

+13
-6
lines changed

1 file changed

+13
-6
lines changed

app/src/main/java/com/paulcoding/hviewer/ui/page/settings/SettingsPage.kt

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ fun SettingsPage(goBack: () -> Boolean) {
6060
val window = (LocalContext.current as MainActivity).window
6161

6262
LaunchedEffect(githubState.siteConfigs) {
63-
if (prevSiteConfigs == null && githubState.siteConfigs != null) {
63+
if (prevSiteConfigs != githubState.siteConfigs) {
6464
goBack()
6565
}
6666
}
@@ -108,17 +108,23 @@ fun SettingsPage(goBack: () -> Boolean) {
108108
}
109109

110110
if (modalVisible)
111-
InputRemoteModal(setVisible = {
112-
modalVisible = it
113-
}) {
111+
InputRemoteModal(
112+
initialText = githubState.remoteUrl,
113+
setVisible = {
114+
modalVisible = it
115+
}) {
114116
Github.updateRemoteUrl(it)
115117
}
116118
}
117119
}
118120

119121
@Composable
120-
fun InputRemoteModal(setVisible: (Boolean) -> Unit, onSubmit: (url: String) -> Unit) {
121-
var text by remember { mutableStateOf("") }
122+
fun InputRemoteModal(
123+
initialText: String = "",
124+
setVisible: (Boolean) -> Unit,
125+
onSubmit: (url: String) -> Unit
126+
) {
127+
var text by remember { mutableStateOf(initialText) }
122128
val focusRequester = remember { FocusRequester() }
123129

124130
fun submit() {
@@ -162,6 +168,7 @@ fun InputRemoteModal(setVisible: (Boolean) -> Unit, onSubmit: (url: String) -> U
162168
keyboardActions = KeyboardActions(
163169
onSend = { submit() }
164170
),
171+
placeholder = { Text("https://github.com/paulcoding810/h-viewer-scripts") }
165172
)
166173
Row(
167174
modifier = Modifier.fillMaxWidth(),

0 commit comments

Comments
 (0)