Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky acceptance tests #480

Open
filipowm opened this issue Jan 3, 2025 · 0 comments
Open

Fix flaky acceptance tests #480

filipowm opened this issue Jan 3, 2025 · 0 comments

Comments

@filipowm
Copy link
Contributor

filipowm commented Jan 3, 2025

As discussed in #461, several acceptance tests are experiencing flakiness, making it difficult to confidently review and merge PRs.

Common Issues:

  • Error during post-test destroy leading to dangling resources 1
  • Duplicate resource names causing tests to fail, like in example 2

Solutions

Temporary:

  • disable or mark flaky tests as allowed to fail until fixed to focus on achieving parity with other providers quickly

Long-term:

  • randomize resource names to avoid conflicts 3
  • address device allocation logic
  • debug and fix the post-test destroy issues

Footnotes

  1. Example run of dangling resources after post-destroy ↩

  2. Example run of duplicate resource names ↩

  3. Example of randomisation of the resource names ↩
filipowm added a commit to filipowm/terraform-provider-unifi that referenced this issue Jan 3, 2025
@filipowm
fix: temporarily disable CheckDestroy in TestAccSite_basic causing te…
c056e13 
…st flakiness

References paultyng#480
filipowm added a commit to filipowm/terraform-provider-unifi that referenced this issue Jan 3, 2025
@filipowm
fix: generate random name and mac in TestAccDataAccount_default and T…
d550ae4 
…estAccDataAccount_mac respectively to fix flakiness

References paultyng#480
joshuaspence pushed a commit that referenced this issue Jan 7, 2025
@filipowm
fix: flaky TestAccSite_basic and TestAccDataAccount_mac tests (#481)
793d566 
* fix: temporarily disable CheckDestroy in TestAccSite_basic causing test flakiness

References #480

* fix: generate random name and mac in TestAccDataAccount_default and TestAccDataAccount_mac respectively to fix flakiness

References #480

* chore: disable linter on testAccCheckSiteResourceDestroy
filipowm added a commit to filipowm/terraform-provider-unifi that referenced this issue Jan 8, 2025
@filipowm
chore: make tests less flaky due to random naming of resources
027c3e9 
Refers paultyng#480
@filipowm filipowm mentioned this issue Jan 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@filipowm