Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: TOML Config Source for MicroProfile Config /FISH-9198 #6822

Closed
poikilotherm opened this issue Jul 12, 2024 · 9 comments · Fixed by #6988
Closed

Enhancement: TOML Config Source for MicroProfile Config /FISH-9198 #6822

poikilotherm opened this issue Jul 12, 2024 · 9 comments · Fixed by #6988
Assignees
Labels
Status: Accepted Confirmed defect or accepted improvement to implement, issue has been escalated to Platform Dev Type: Enhancement Label issue as an enhancement request

Comments

@poikilotherm
Copy link
Contributor

poikilotherm commented Jul 12, 2024

Brief Summary

I would like to be able to use a TOML file as a source for configuration values. This is a standard feature for SmallRye and should be included in Payara, too.

Expected Outcome

Just configure a source and read away that TOML file!

Current Outcome

I'm stuck with adding such a config source to the application, which does not allow me to provide values for early init stuff like ${MPCONFIG=...:...} variable replacements.

Alternatives

Implement a fake JDBC driver to read TOML files.

Been there, done that: gdcc/jdbc-conffile-driver Works, but is hacky. Also: a config source that reads a local file can be updated on change and doesn't need 60 secs default caching! But this will require more control over what's going on, which is just not possible with the JDBC workaround.

Context

As with the DirConfigSource (#5006 / #5007), I would be willing and able to create a pull request and donate the necessary code. If accepted, we should talk about the location for this config source (fish.payara.microprofile.config.extensions vs fish.payara.nucleus.microprofile.config.source) and potentially about using a different caching strategy for it.

@poikilotherm poikilotherm added Status: Open Issue has been triaged by the front-line engineers and is being worked on verification Type: Enhancement Label issue as an enhancement request labels Jul 12, 2024
@artur-mal
Copy link

The proposed enhancement has been submitted for an open vote.

@artur-mal artur-mal added Status: Voting Enhancement request has been submitted to an open vote to engage users and removed Status: Open Issue has been triaged by the front-line engineers and is being worked on verification labels Jul 16, 2024
@poikilotherm
Copy link
Contributor Author

Hi @artur-mal !

It looks like this is a community wanted feature with 22 votes ATM.

What are the next steps? Is a community contribution welcome?

Cheers,
Oliver

Copy link

github-actions bot commented Aug 1, 2024

Greetings,
This enhancement request has been selected by the Payara Community as the most voted enhancement of this month and
thus will be escalated to our product development backlog.

@github-actions github-actions bot added Status: Open Issue has been triaged by the front-line engineers and is being worked on verification and removed Type: Enhancement Label issue as an enhancement request Status: Voting Enhancement request has been submitted to an open vote to engage users labels Aug 1, 2024
@artur-mal
Copy link

Hi @poikilotherm

We welcome community contributions. If you’re interested in contributing, please take a moment to read our contributing guidelines: LINK

If you prefer not to contribute, this enhancement will be handled by the Payara Product Development team.

@artur-mal artur-mal added Status: Pending Waiting on the issue requester to give more details or share a reproducer Type: Enhancement Label issue as an enhancement request and removed Status: Open Issue has been triaged by the front-line engineers and is being worked on verification labels Aug 6, 2024
@Pandrex247
Copy link
Member

We've raised an internal issue to track this enhancement with the ID of FISH-9198.

@MeroRai MeroRai added Status: Accepted Confirmed defect or accepted improvement to implement, issue has been escalated to Platform Dev and removed Status: Pending Waiting on the issue requester to give more details or share a reproducer labels Aug 8, 2024
@fturizo fturizo changed the title Enhancement: TOML Config Source for MicroProfile Config Enhancement: TOML Config Source for MicroProfile Config /FISH-9198 Aug 14, 2024
@DS-INRAE
Copy link

Hello, @Pandrex247 are there any news on the status or priority of this enhancement ? 🙂

@kalinchan
Copy link
Member

This is currently being implemented and is targeted to be in the 6.2024.11 release.

@poikilotherm
Copy link
Contributor Author

Great news! Keep up the good work! Woohoo! 🥰🥳

@kalinchan
Copy link
Member

Hi @poikilotherm, I have made the PR to support TOML, feel free to test the changes. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Confirmed defect or accepted improvement to implement, issue has been escalated to Platform Dev Type: Enhancement Label issue as an enhancement request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants