Skip to content

Commit bf85891

Browse files
committed
PipeCommand: pass shell arg to ExternalCommand.
Prior to this branch, `shell=True` was passed to Popen regardless of whether `--shell` was passed. I'm not sure why this was the case but it wasn't a problem. Now that we're passing to ExternalCommand, this doesn't work because ExternalCommand does it's own manipulation of cmd when shell=False which is incompatible with a list-style cmd.
1 parent be3a0bd commit bf85891

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

alot/commands/thread.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -795,7 +795,7 @@ def callback(out):
795795

796796
await ui.apply_command(ExternalCommand(cmd,
797797
stdin=mail,
798-
shell=True,
798+
shell=self.shell,
799799
thread=self.background,
800800
on_success=callback))
801801

0 commit comments

Comments
 (0)