From 6f53dcb3f31a7c54cd6171e54ba7b23d4cfdfedc Mon Sep 17 00:00:00 2001 From: Chris Smith Date: Tue, 31 Oct 2023 22:10:19 -0500 Subject: [PATCH 1/5] fix to_euler docstring --- sympy/algebras/quaternion.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sympy/algebras/quaternion.py b/sympy/algebras/quaternion.py index b4d1c9b45fe2..e5a8ee2d90bf 100644 --- a/sympy/algebras/quaternion.py +++ b/sympy/algebras/quaternion.py @@ -383,9 +383,9 @@ def from_euler(cls, angles, seq): The Euler angles (in radians). seq : string of length 3 Represents the sequence of rotations. - For intrinsic rotations, seq must be all lowercase and its elements + For extrinsic rotations, seq must be all lowercase and its elements must be from the set ``{'x', 'y', 'z'}`` - For extrinsic rotations, seq must be all uppercase and its elements + For intrinsic rotations, seq must be all uppercase and its elements must be from the set ``{'X', 'Y', 'Z'}`` Returns @@ -448,9 +448,9 @@ def to_euler(self, seq, angle_addition=True, avoid_square_root=False): seq : string of length 3 Represents the sequence of rotations. - For intrinsic rotations, seq must be all lowercase and its elements + For extrinsic rotations, seq must be all lowercase and its elements must be from the set ``{'x', 'y', 'z'}`` - For extrinsic rotations, seq must be all uppercase and its elements + For intrinsic rotations, seq must be all uppercase and its elements must be from the set ``{'X', 'Y', 'Z'}`` angle_addition : bool From 4e2f4b643015de4c2c17708eb1ff6b1f4803acca Mon Sep 17 00:00:00 2001 From: Chris Smith Date: Wed, 1 Nov 2023 08:39:34 -0500 Subject: [PATCH 2/5] update mailmap --- .mailmap | 1 + 1 file changed, 1 insertion(+) diff --git a/.mailmap b/.mailmap index 1f673809c774..cbc670d32cea 100644 --- a/.mailmap +++ b/.mailmap @@ -1224,6 +1224,7 @@ Sagar Bharadwaj Sagar231 Sahil Shekhawat Sai Nikhil +Saicharan <62512681+saicharan2804@users.noreply.github.com> Saicharan Saikat Das Saket Kumar Singh From aa0ec99a7b9d1a0e09ddadebd28afb9f84d0b5bc Mon Sep 17 00:00:00 2001 From: Christopher Smith Date: Wed, 1 Nov 2023 09:29:33 -0500 Subject: [PATCH 3/5] Update .mailmap --- .mailmap | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.mailmap b/.mailmap index cbc670d32cea..34a30dbe1553 100644 --- a/.mailmap +++ b/.mailmap @@ -1224,8 +1224,7 @@ Sagar Bharadwaj Sagar231 Sahil Shekhawat Sai Nikhil -Saicharan <62512681+saicharan2804@users.noreply.github.com> -Saicharan +Saicharan <62512681+saicharan2804@users.noreply.github.com> Saikat Das Saket Kumar Singh Saketh From d42887aef19b777f6f800c03087e237a5ba67783 Mon Sep 17 00:00:00 2001 From: Christopher Smith Date: Wed, 1 Nov 2023 11:37:58 -0500 Subject: [PATCH 4/5] Update .mailmap --- .mailmap | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.mailmap b/.mailmap index f88c92a62252..3877355803a4 100644 --- a/.mailmap +++ b/.mailmap @@ -1223,7 +1223,8 @@ Sagar Bharadwaj Sagar231 Sahil Shekhawat Sai Nikhil -Saicharan <62512681+saicharan2804@users.noreply.github.com> +Saicharan +Saicharan <62512681+saicharan2804@users.noreply.github.com> Saikat Das Saket Kumar Singh Saketh From 243f2aed41fbd3acf37e5189b9c74a71991a4b3a Mon Sep 17 00:00:00 2001 From: Christopher Smith Date: Wed, 1 Nov 2023 11:43:11 -0500 Subject: [PATCH 5/5] Update .mailmap --- .mailmap | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.mailmap b/.mailmap index 3877355803a4..1d7fa296b7b4 100644 --- a/.mailmap +++ b/.mailmap @@ -1223,8 +1223,8 @@ Sagar Bharadwaj Sagar231 Sahil Shekhawat Sai Nikhil -Saicharan Saicharan <62512681+saicharan2804@users.noreply.github.com> +Saicharan Saikat Das Saket Kumar Singh Saketh