New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only start log message counting background threads if applicable #325

Open

klauer opened this issue Mar 11, 2022 · 0 comments

Contributor

klauer commented Mar 11, 2022 •

edited

Loading

Why have a bunch of background threads counting log messages if there is no threshold above which they would be silenced?

This can be changed:

hutch-python/hutch_python/log_setup.py

Lines 352 to 354 in 5015ab0

    
           self._timer = threading.Thread(target=self._count_update_thread) 
        
           self._timer.daemon = True 
        
           self._timer.start()

Or we can look to reverting the spammy log message thing entirely. While well-intentioned, I think it was a mistake in retrospect...

Context: Noted in segfault in Travis CI: https://app.travis-ci.com/github/pcdshub/hutch-python/jobs/562743057

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment