Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guards against network error #2

Open
xrmx opened this issue Apr 17, 2018 · 1 comment
Open

guards against network error #2

xrmx opened this issue Apr 17, 2018 · 1 comment

Comments

@xrmx
Copy link
Collaborator

xrmx commented Apr 17, 2018

No idea if a plugin crashing breaks the build. If so the urllib call should be inside a try block, and if we get an error we should just break the loop

@pdavide
Copy link
Owner

pdavide commented Apr 17, 2018

A plugin crash breaks the build indeed.
As the build task is a long running process, I think that, if a network error occurs, we can try a fixed number of times before giving up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants