-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix clippy warnings #30
Comments
There are a few rustc warnings now that should definitely be fixed. I don't know what kinds of things clippy suggests be changed but I assume those are fine too. One thing I haven't done yet that would be useful for those kinds of refactorings is getting an automated regression testing setup by making sure the output stays exactly the same over the test set in |
Regression tests would be great for a library like this. I found this library and will check it out: retest |
My plan for this was actually quite simple:
Since doing the raw processing without the image pipeline is very fast, it should be a pretty fast test run that can be used on every PR/commit. The only problem is that it requires having quite a few GB of test images locally. I don't know if that means I can't do that test in travis for automation and need to set it up in my own server and integrate with GitHub. |
I will definitely do this before I create a PR for the Clippy-Warnings. I'm just really busy right now. That's why it may take a while. |
Hi Pedro,
I would like to fix some
clippy
-warnings in the code, if this is ok for you.Best regards,
Maximilian
The text was updated successfully, but these errors were encountered: