We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hello,
I found a bug with firefox when click on the active image : The event is not fired. It is because the event is attached into the <button /> but on firefox it has a 0px x 0px size. It come from here https://github.com/peterpalau/react-bnb-gallery/blob/ebb11378048450ab9f75484847ac892fbfc9c35e/src/components/Image/Image.js#L144 You put a div element into a button, it's not allowed by the specs : https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button
<button />
0px x 0px
Permitted content | Phrasing content but there must be no Interactive content https://developer.mozilla.org/en-US/docs/Web/Guide/HTML/Content_categories#Phrasing_content
So the size flow is broken here, and when we click on the image, the event is not fire on the button but on the parent element li
li
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Hello,
I found a bug with firefox when click on the active image :
The event is not fired.
It is because the event is attached into the
<button />but on firefox it has a0px x 0pxsize.It come from here https://github.com/peterpalau/react-bnb-gallery/blob/ebb11378048450ab9f75484847ac892fbfc9c35e/src/components/Image/Image.js#L144
You put a div element into a button, it's not allowed by the specs :
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button
So the size flow is broken here, and when we click on the image, the event is not fire on the button but on the parent element
liThe text was updated successfully, but these errors were encountered: