Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store registrar signature deadline in the Record #2

Closed
3 tasks done
peersky opened this issue Sep 30, 2024 · 1 comment
Closed
3 tasks done

Store registrar signature deadline in the Record #2

peersky opened this issue Sep 30, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@peersky
Copy link
Member

peersky commented Sep 30, 2024

Currently we check registrar signature timeout during submit of the record.

In order to allow easier lookup on date validity, we want to add signature validity time to the record.

To do that, we need

  • Add validUntil to LibMultipass.DomainStorage
  • add validUntil to Record
  • add public interface for validity verification `isValid(LibMultipass.NameQuery memory query) returns (bool)

Add tests:

  • It returns correct validUntil parameter in user query
  • It returns true for isValid if validUntil > msg.timestamp and false otherwise
  • modifyUserName function requires validUntil to be longer than currently issued
@peersky peersky added the good first issue Good for newcomers label Sep 30, 2024
@peersky
Copy link
Member Author

peersky commented Oct 16, 2024

completed in #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant