Merge pull request #26 from pelias/fix-numeric-sorting-bug

missinglink · web-flow · commit 131ec0198865 · 2022-06-20T23:48:21.000+12:00
fix numeric sorting bug
diff --git a/index.js b/index.js
@@ -84,7 +84,8 @@ function resolveByFocusPointThenOtherField(isLayer, field, result1, result2, foc
     }
 
     // no focus point, so on another field (currently only population or popularity)
-    return result2[field] - result1[field];
+    // note: (undefined-undefined==NaN) which is not an acceptable comparitor value
+    return _.defaultTo(result2[field], 0) - _.defaultTo(result1[field], 0);
 
   }
 

Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,8 @@ function resolveByFocusPointThenOtherField(isLayer, field, result1, result2, foc`
`84`	`84`	`}`
`85`	`85`
`86`	`86`	`// no focus point, so on another field (currently only population or popularity)`
`87`		`- return result2[field] - result1[field];`
	`87`	`+ // note: (undefined-undefined==NaN) which is not an acceptable comparitor value`
	`88`	`+ return _.defaultTo(result2[field], 0) - _.defaultTo(result1[field], 0);`
`88`	`89`
`89`	`90`	`}`
`90`	`91`