Docker

[lancepioch]

No description provided.

[parkervcp]

Looks good to me. We should probably fire this up where it's actually on the internet to see how it goes before we fully release it.

We can add more compose files later. Some with all the things needed for redis/valkey and mariadb support.

[luthes]

I've been digging into this a bit, both testing the Compose as well as the container builds, and tinkering with Helm. I run entirely in k8s any more, and having everything so tightly coupled in the current Dockerfile causes issues there.

That being said, I was able to split out Caddy and the Panel with Docker Compose (and Helm as well), by simply overriding commands, and editing and mounting the config file. But I do believe the base Dockerfile for the Panel should not bundle Caddy, each component (Caddy, Panel, Redis, etc.) should be it's own service.

From what I've been looking into this evening, what's needed to make this more micro-service friendly is:

• Use volumes to provide access to /var/www/html files in Compose, rather than COPY . . in the Docker build.
• Existing Panel Dockerfile should not bundle anything that's not necessary to running php-fpm.
• Caddyfile needs updated to use Docker overlay network, rather than localhost

Just a note that I'm willing to work on the above if you'd accept a PR. Let me know what you think of the above or if you're looking to go a different direction, happy to help.

[LumiKattlin]

On the "composer install --no-dev --optimize-autoloader" part from the docker-compose, after reaching it, it returns the error code 2

This is the logs:

Composer could not detect the root package (pelican-dev/panel) version, defaulting to '1.0.0'. See https://getcomposer.org/root-version
Installing dependencies from lock file
Verifying lock file contents can be installed on current platform.
Warning: The lock file is not up to date with the latest changes in composer.json. You may be getting outdated dependencies. It is recommended that you run `composer update` or `composer update <package name>`.
Your lock file does not contain a compatible set of packages. Please run composer update.

  Problem 1
    - Root composer.json requires PHP extension ext-pdo_mysql * but it is missing from your system. Install or enable PHP's pdo_mysql extension.

To enable extensions, verify that they are enabled in your .ini files:
    - /usr/local/etc/php/conf.d/docker-fpm.ini
    - /usr/local/etc/php/conf.d/docker-php-ext-bcmath.ini
    - /usr/local/etc/php/conf.d/docker-php-ext-gd.ini
    - /usr/local/etc/php/conf.d/docker-php-ext-intl.ini
    - /usr/local/etc/php/conf.d/docker-php-ext-opcache.ini
    - /usr/local/etc/php/conf.d/docker-php-ext-pcntl.ini
    - /usr/local/etc/php/conf.d/docker-php-ext-sodium.ini
    - /usr/local/etc/php/conf.d/docker-php-ext-zip.ini
You can also run `php --ini` in a terminal to see which files are used by PHP in CLI mode.
Alternatively, you can run Composer with `--ignore-platform-req=ext-pdo_mysql` to temporarily ignore these required extensions.
The command '/bin/sh -c composer install --no-dev --optimize-autoloader' returned a non-zero code: 2

[parkervcp]

@LumiKattlin did you have this issue while building the container? I just tried out a build and it worked.

Have you tried this recently?

[LumiKattlin]

Yeah, dw, it ended up being a mistake on my part

ended up working 👍

[VozDeOuro]

@parkervcp sorry for ping, do you have any ETA on when this will be merged ?

[parkervcp]

Well that was ugly

re-review plz

[parkervcp]

LGTM