Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

newer contacts.json and pairs.json don't use "_1" naming convention #3

Open
mivade opened this issue Mar 19, 2018 · 1 comment
Open

newer contacts.json and pairs.json don't use "_1" naming convention #3

mivade opened this issue Mar 19, 2018 · 1 comment

Comments

@mivade
Copy link
Contributor

mivade commented Mar 19, 2018

In older subjects, the contacts.json and pairs.json files used subject IDs such as R1059J_1 when a relocalization/remontage happens. Newer subjects (e.g. R1394E) do not and should be fixed to use the same behavior.
@mivade
Copy link
Contributor Author

mivade commented Mar 29, 2018

@leondavis1 should we update existing contacts/pairs.json to make them all the same? Or should we just document this and deal with it appropriately?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mivade