Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS settings on testnet GRPC endpoint are broken again #4318

Closed
hdevalence opened this issue May 4, 2024 · 1 comment
Closed

CORS settings on testnet GRPC endpoint are broken again #4318

hdevalence opened this issue May 4, 2024 · 1 comment
Assignees
Labels
needs-refinement unclear, incomplete, or stub issue that needs work _P-high High priority _P-V1 Priority: slated for V1 release

Comments

@hdevalence
Copy link
Member

Describe the bug

https://buf.build/studio/penumbra-zone/penumbra/penumbra.core.app.v1.QueryService/AppParameters?target=https%3A%2F%2Fgrpc.testnet.penumbra.zone&selectedProtocol=grpc-web&share=s2KqrgUA

Does not work in FF with a CORS error.

@github-project-automation github-project-automation bot moved this to Backlog in Penumbra May 4, 2024
@github-actions github-actions bot added the needs-refinement unclear, incomplete, or stub issue that needs work label May 4, 2024
@hdevalence hdevalence added _P-high High priority _P-V1 Priority: slated for V1 release labels May 4, 2024
@conorsch conorsch self-assigned this May 6, 2024
@conorsch
Copy link
Contributor

conorsch commented May 6, 2024

Tested this shortly after you reported it, and was able to reproduce, although I didn't bother to screenshot it. Intriguingly, the problem was also evident on the solo node https://solo-pd.testnet.plinfra.net (buf studio link), so it definitely wasn't any reverse-proxies that we run causing the problem. We added an integration test in #3870 to guard against regressions, and that hasn't failed, and polling the endpoints directly shows that they're still serving correctly:

curl results on endpoint calls
❯ curl -I https://grpc.testnet.penumbra.zone
HTTP/2 200
access-control-allow-origin: *
access-control-expose-headers: *
content-type: text/html
date: Mon, 06 May 2024 15:05:08 GMT
vary: origin
vary: access-control-request-method
vary: access-control-request-headers
content-length: 481

❯ curl -I https://solo-pd.testnet.plinfra.net
HTTP/2 200
content-type: text/html
content-length: 481
access-control-allow-origin: *
vary: origin
vary: access-control-request-method
vary: access-control-request-headers
access-control-expose-headers: *
date: Mon, 06 May 2024 15:05:19 GMT

Testing this morning, however, showed it's working just fine:

buf-studio-working-again

No changes were made to any of our deployments. Therefore I believe this a transitory change on Buf's end, although I can't find a citation for that. I also made sure to test in Chrome, and Buf Studio is working well with both our endpoints linked above. I'm closing this issue for now, but please re-open if you are still having problems!

@conorsch conorsch closed this as completed May 6, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Penumbra May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-refinement unclear, incomplete, or stub issue that needs work _P-high High priority _P-V1 Priority: slated for V1 release
Projects
Archived in project
Development

No branches or pull requests

2 participants