Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-think key generation #7

Open
JJ opened this issue Sep 29, 2019 · 0 comments
Open

Re-think key generation #7

JJ opened this issue Sep 29, 2019 · 0 comments
Labels
question Further information is requested

Comments

@JJ
Copy link
Contributor

JJ commented Sep 29, 2019

Right now the key to store the files is computed from the file name; files with the same name and different paths will be stored in the same directory. I'm not sure why this is done this way, but it might make sense because file names are usually more unique than directory names. However, this is not explicit anywhere and it might cause trouble down the road.
This is now encapsulated in the class, so we might change it when we want, but we need to know how it's used and how caches are retrieved just in case.

@JJ JJ added the question Further information is requested label Sep 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant