Merge pull request WebOfTrust#134 from psteniusubi/fix-improve-accept-error-message

Improve startup error message when bind on http port fails

Author: m00sey

src/keria/app/agenting.py

@@ -59,6 +59,8 @@ def setup(name, bran, adminPort, bootPort, base='', httpPort=None, configFile=No
                         'signify-resource', 'signify-timestamp']))
 
     bootServer = createHttpServer(bootPort, bootApp, keypath, certpath, cafilepath)
+    if not bootServer.reopen():
+        raise RuntimeError(f"cannot create boot http server on port {bootPort}")
     bootServerDoer = http.ServerDoer(server=bootServer)
     bootEnd = BootEnd(agency)
     bootApp.add_route("/boot", bootEnd)
@@ -77,6 +79,8 @@ def setup(name, bran, adminPort, bootPort, base='', httpPort=None, configFile=No
     app.resp_options.media_handlers.update(media.Handlers())
 
     adminServer = createHttpServer(adminPort, app, keypath, certpath, cafilepath)
+    if not adminServer.reopen():
+        raise RuntimeError(f"cannot create admin http server on port {adminPort}")
     adminServerDoer = http.ServerDoer(server=adminServer)
 
     doers = [agency, bootServerDoer, adminServerDoer]
@@ -100,6 +104,8 @@ def setup(name, bran, adminPort, bootPort, base='', httpPort=None, configFile=No
         indirecting.loadEnds(agency=agency, app=happ)
 
         server = createHttpServer(httpPort, happ, keypath, certpath, cafilepath)
+        if not server.reopen():
+            raise RuntimeError(f"cannot create local http server on port {httpPort}")
         httpServerDoer = http.ServerDoer(server=server)
         doers.append(httpServerDoer)
 

tests/app/test_agenting.py

@@ -28,11 +28,12 @@
 from keria.core import longrunning
 
 
-def test_setup():
+def test_setup_no_http():
     doers = agenting.setup(name="test", bran=None, adminPort=1234, bootPort=5678)
     assert len(doers) == 3
     assert isinstance(doers[0], agenting.Agency) is True
 
+def test_setup():
     doers = agenting.setup("test", bran=None, adminPort=1234, bootPort=5678, httpPort=9999)
     assert len(doers) == 4