Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review how we might migrate to using cookie-rs Cookies directly #7

Open
pfernie opened this issue May 23, 2017 · 0 comments
Open

Review how we might migrate to using cookie-rs Cookies directly #7

pfernie opened this issue May 23, 2017 · 0 comments

Comments

@pfernie
Copy link
Owner

pfernie commented May 23, 2017

There are some extra fields/parsing requirements user_agent uses (access timestamps, etc.), that may not be appropriate for upstreaming. Furthermore, cookie-rs strives to be no allocation where possible, which may be at odds with some of the normalization/canonicalization steps taken in user_agent.

However, maybe moving some fields to a more aptly named CookieMetadata or similar struct, containing a cookie::Cookie might make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant