-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A question about parse a dns package #12
Comments
I think you mean line 127 of strutils.c. If a name contains a
non-printable/illegal character, then yes, that is an invalid DNS packet.
Should we still record it though? Absolutely! Dns_parse is for network
monitoring, and if we have strange, illegal dns packets flowing around we
want to know about them.
…On Thu, Jan 19, 2017 at 6:20 AM, BearGrass ***@***.***> wrote:
Hi
I have learnd your beautiful code for parsing DNS package. And I have a
question in 127 line of dns_parse.c. Why you judge the value of c ? In my
opinion,if "c" is a normal charactor ,i will put it in name. But , if not,i
will drop the pacage ,becase it is a illegal package. THX ,holp for answer.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#12>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADFpUZhKsK9OYaNsfrkh13IUj7Xkjnoks5rT2MwgaJpZM4LoGgA>
.
--
Paul Ferrell
pflarr@gmail.com
|
Understand ! thank you very much |
Hi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi
I have learnd your beautiful code for parsing DNS package. And I have a question in 127 line of dns_parse.c. Why you judge the value of c ? In my opinion,if "c" is a normal charactor ,i will put it in name. But , if not,i will drop the pacage ,becase it is a illegal package. THX ,waiting for your answer.
The text was updated successfully, but these errors were encountered: