Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(phpshell): run inline php-shell code #88

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(phpshell): run inline php-shell code #88

wants to merge 1 commit into from

Conversation

genofire
Copy link
Contributor

No description provided.

@genofire genofire force-pushed the feat/phpshell branch 3 times, most recently from c332d47 to 07f61f3 Compare August 25, 2023 16:04
@genofire
Copy link
Contributor Author

How does i get the linter happy?
There are no usefull debug messages.

opoplawski
opoplawski requested changes Aug 26, 2023
View reviewed changes
plugins/modules/pfsense_phpshell.py Outdated Show resolved Hide resolved
@genofire genofire force-pushed the feat/phpshell branch 2 times, most recently from d4a3450 to 23e43c2 Compare October 13, 2023 07:26
@opoplawski
Copy link
Contributor

I'm assuming these are straightforward:

ERROR: Found 3 pep8 issue(s) which need to be resolved:
ERROR: plugins/modules/pfsense_phpshell.py:56:21: W291: trailing whitespace
ERROR: plugins/modules/pfsense_phpshell.py:83:1: E302: expected 2 blank lines, found 1
ERROR: plugins/modules/pfsense_phpshell.py:117:1: E303: too many blank lines (3)

opoplawski
opoplawski requested changes Dec 23, 2023
View reviewed changes
Copy link
Contributor

@opoplawski opoplawski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in the system patch review - I think this might be better in a different collection. Not sure this is generally of interest for most pfsense users. Unless you have some specific common usecases?

plugins/modules/pfsense_phpshell.py Outdated Show resolved Hide resolved
plugins/modules/pfsense_phpshell.py Outdated Show resolved Hide resolved
plugins/modules/pfsense_phpshell.py Outdated Show resolved Hide resolved
plugins/modules/pfsense_phpshell.py Outdated Show resolved Hide resolved
@genofire genofire force-pushed the feat/phpshell branch 5 times, most recently from ac6859c to 0d7d771 Compare January 2, 2024 21:53
@genofire genofire mentioned this pull request Jan 2, 2024
Open
@genofire
Copy link
Contributor Author

Please say me where this collection is? or do you like to move it around?

@opoplawski
Copy link
Contributor

Actually on second thought I think I'm fine with this being in the core collection.

@genofire
Copy link
Contributor Author

Nice, still something todo here?

opoplawski
opoplawski requested changes Jan 31, 2024
View reviewed changes
plugins/modules/pfsense_phpshell.py Outdated
DOCUMENTATION = """
---
module: pfsense_phpshell
version_added: 0.6.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to get bumped to 0.6.2

@genofire genofire requested a review from opoplawski June 19, 2024 10:05
@genofire
Copy link
Contributor Author

Sorry for the delay, here the changes with an rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opoplawski opoplawski Awaiting requested review from opoplawski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@genofire @opoplawski