Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fw support floating 'all' interface rule #90

Merged
merged 2 commits into from
Jan 7, 2024
Merged

fw support floating 'all' interface rule #90

merged 2 commits into from
Jan 7, 2024

Conversation

GuideGlyph
Copy link
Contributor

Add support for 'All' interface when creating floating firewall rule

Before
изображение

After
изображение
изображение

opoplawski
opoplawski requested changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@opoplawski opoplawski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. In addition to the other comment, please document the use of 'any' in module parameter documentation.

plugins/module_utils/rule.py Outdated Show resolved Hide resolved
@opoplawski opoplawski added this to the 0.6.0 milestone Dec 23, 2023
@opoplawski opoplawski added the enhancement New feature or request label Dec 23, 2023
@opoplawski opoplawski merged commit dce1ce8 into pfsensible:master Jan 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opoplawski opoplawski opoplawski requested changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@GuideGlyph @opoplawski