Skip to content

Worker - Unraid #2611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blaine07 opened this issue Oct 11, 2024 · 17 comments
Open

Worker - Unraid #2611

blaine07 opened this issue Oct 11, 2024 · 17 comments
Labels

Comments

@blaine07
Copy link

How would I add this new worker to an instance of PasswordPusher on Unraid? Just add another container that is the worker or is there anything else special I would need to take into consideration ?

@pglombardo
Copy link
Owner

Hi @blaine07 - that's correct. Just run it with the same environment settings as the pwpush container. There are no exposed ports required.

Note though that this worker only functions with a shared database (Postgres, MySQL or MariaDB). If using ephemeral, it's no use in that setup.

The worker just runs these periodic background jobs right now.

I'll have documentation in the next week or so.

@blaine07
Copy link
Author

Hi @blaine07 - that's correct. Just run it with the same environment settings as the pwpush container. There are no exposed ports required.

Note though that this worker only functions with a shared database (Postgres, MySQL or MariaDB). If using ephemeral, it's no use in that setup.

The worker just runs these periodic background jobs right now.

I'll have documentation in the next week or so.

So, I legitimately shouldn't see any ill effects if I don't immediately spin this up?

@pglombardo
Copy link
Owner

pglombardo commented Oct 11, 2024

So, I legitimately shouldn't see any ill effects if I don't immediately spin this up?

Definitely not. It just runs periodic jobs to find pushes to expire.

But also these are the initial releases so there might be occasional errors etc.. but you can watch the output with docker log.

@blaine07
Copy link
Author

So, I legitimately shouldn't see any ill effects if I don't immediately spin this up?

Definitely not. It just runs periodic jobs to find pushes to expire.

But also these are the initial releases so there might be occasional errors etc.. but you can watch the output with docker log.

Before this worker how were pushes getting expired and cleaned up?

@pglombardo
Copy link
Owner

pglombardo commented Oct 11, 2024

The original design was that people add a cron to run the background tasks.

If those didn't run - then it was lazy deletion. When a push is requested, it's expiration limits are checked before serving. If duration or views are eaten up, then the push is expired and data is deleted there - then you get the "this link has expired" page.

@pglombardo
Copy link
Owner

Did you have any problems deploying @blaine07? Soon I'll have a dashboard where you can view job executions.

@pglombardo
Copy link
Owner

A couple of screenshots in #2638

@blaine07
Copy link
Author

Did you have any problems deploying @blaine07? Soon I'll have a dashboard where you can view job executions.

I just added it as another container; so far seems fine. It keeps wanting to exit itself/stop itself from running in the middle of the night though for some weird reason; not seeing any errors or anything. Maybe I need to add a "--restart unless-stopped"

@pglombardo
Copy link
Owner

Ok - yeah that's a good idea. I'll figure out why the workers are dying.

@blaine07
Copy link
Author

Ok - yeah that's a good idea. I'll figure out why the workers are dying.

Does this tell you anything?

image

@pglombardo
Copy link
Owner

I believe this means that the database container was restarted. Not sure about this one.

The --restart unless-stopped probably would be a good first step and then looking into if the db container was restarted/why.

@pglombardo
Copy link
Owner

Hi @blaine07 - I considering to run the background worker in the core pwpush container... #3170

Having a separate pwpush-worker just adds complexity. Feedback welcome.

FYI.

@blaine07
Copy link
Author

blaine07 commented Mar 11, 2025

Hi @blaine07 - I considering to run the background worker in the core pwpush container... #3170

Having a separate pwpush-worker just adds complexity. Feedback welcome.

FYI.

I think that would be a good idea. Two containers on Unraid being separately, like current, is certainly not ideal.

Unrelated: are you releasing self hosted pro options soon?

@pglombardo
Copy link
Owner

Unrelated: are you releasing self hosted pro options soon?

Working on it. Target is no later than June but hopefully sooner. That self-hosted Pro will likely bundle the worker too (which is what triggered this change).

@blaine07
Copy link
Author

Unrelated: are you releasing self hosted pro options soon?

Working on it. Target is no later than June but hopefully sooner. That self-hosted Pro will likely bundle the worker too (which is what triggered this change).

Is the idea or plan that something like that cost something reasonable so normal folks using this in a limited non commercial setting will still see it as viable "for fun" thing to have and continue to use sir?

@pglombardo
Copy link
Owner

No charge for you @blaine07. The subscriptions are primarily targeted at organizations to accelerate the project. I'll message other long time contributors as well once it's out.

@blaine07
Copy link
Author

No charge for you @blaine07. The subscriptions are primarily targeted at organizations to accelerate the project. I'll message other long time contributors as well once it's out.

Whatever I can do to help you. Over 😊👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants