Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add media properties to downloaded file. #7

Open
freedahealth opened this issue Jul 19, 2019 · 4 comments
Open

Add media properties to downloaded file. #7

freedahealth opened this issue Jul 19, 2019 · 4 comments

Comments

@freedahealth
Copy link

No media properties created for the mp3 file, when download mp3 option is selected.

@freedahealth
Copy link
Author

@pgmichael - I don't think this should be considered just an enhancement. When the file is created without any media properties (specifically "Length") it causes many programs to "ignore it" because it thinks it is 0.00 seconds long.

@pgmichael pgmichael added the bug label Jul 23, 2019
@pgmichael
Copy link
Owner

@freedahealth thanks for the feedback, I'll change the label. To be honest, I'm not very familiar with media properties and how they work. I'll have to do a little research before working on this issue.

@yucolabjames
Copy link

@pgmichael what you need is an ID3v2 writer which can edit MP3's meta data.

Something like this will work for JS Blobs: https://github.com/egoroof/browser-id3-writer

You will need to modify/ add the TLEN property, which according to the official spec accepts value in ms.

The 'Length' frame contains the length of the audiofile in milliseconds, represented as a numeric string.

Reference:
http://id3.org/d3v2.3.0
https://en.wikipedia.org/wiki/ID3#ID3v2_frame_specification

@pgmichael
Copy link
Owner

@yucolabjames Thanks a lot for the information! I wasn't having much luck with my google searches.

@pgmichael pgmichael changed the title MP3 Add media properties to downloaded file Feb 20, 2020
@pgmichael pgmichael changed the title Add media properties to downloaded file Add media properties to downloaded file. Mar 1, 2020
@pgmichael pgmichael removed bug labels Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants