Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuous Redirect Loop in Documentation URLs When Changing Phalcon Version #145

Open
andihoerudin24 opened this issue May 14, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@andihoerudin24
Copy link

I found an issue or bug in the Phalcon documentation at https://docs.phalcon.io/4.2/db-phql/.
When I change the version to 4.2 directly from the URL, for example, https://docs.phalcon.io/3.7/db-phql/ and then press enter, the browser will encounter an error with continuous redirects, like this: https://docs.phalcon.io/3.7/db-phql/latest/latest/latest/latest/latest/latest/latest/.

@Andrii-Pokh
Copy link

Yep, I also faced with similar issue.
It seems when we have this: https://docs.phalcon.io/wrong_number/db-phql/ or this https://docs.phalcon.io/empty_value/db-phql/ in url, route is not found and we have continuous redirect loop.

@elcreator
Copy link

Reproducible even without version change just by clicking on the link to any non-existing URL with version number (i.e. old docs of new functionality #191 ).

I.e. you click on https://docs.phalcon.io/3.7/db-phql/ link it will be reproduced but it will not if you click on https://docs.phalcon.io/5.7/db-phql/ .
If you click on https://docs.phalcon.io/something-12345 it will correctly redirect to https://docs.phalcon.io/latest/introduction but the bug will be reproduced if you click on https://docs.phalcon.io/3.7/something-12345 .

@niden
Copy link
Member

niden commented Aug 25, 2024

This one I am still trying to figure it out.

In the past we could just put a redirect with a wildcard on the docs page and it will sort things out on its own.

With the new versioned deployment of our docs (using mike), GitHub actions creates the content (the final HTML files) and Cloudflare just uploads it, hence there are no redirects there.

I am thinking to remove the latest part from the docs and leave it only for Cloudflare to deal with.

Sorry for taking so long, this is not as easy to fix as before.

@niden niden added the bug Something isn't working label Aug 25, 2024
@niden niden self-assigned this Aug 25, 2024
@niden niden added this to Phalcon v5 Aug 25, 2024
@niden niden moved this to In Progress in Phalcon v5 Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: In Progress
Development

No branches or pull requests

4 participants